Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for older Android Gradle plugin #4707

Merged
merged 4 commits into from
Jul 6, 2022
Merged

Conversation

tomduncalf
Copy link
Contributor

@tomduncalf tomduncalf commented Jul 6, 2022

What, How & Why?

#4697 inadvertently changed the minimum Android Gradle plugin version required when using Realm to 4.2.x. This change fixes that by wrapping the code in question in a version check, and adding a fallback to the old syntax for older Android Gradle versions (probably not strictly necessary but this would allow us to debug apps using the older Android Gradle version without modification).

I also reverted the test app back to the old version, so that we are still testing that version on CI

Fixes #4706

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@cla-bot cla-bot bot added the cla: yes label Jul 6, 2022
@tomduncalf tomduncalf changed the title Add fix for older android gradle plugin Add fix for older Android Gradle plugin Jul 6, 2022
@tomduncalf tomduncalf requested review from kneth and kraenhansen July 6, 2022 09:47
@tomduncalf tomduncalf merged commit 67c6559 into master Jul 6, 2022
@tomduncalf tomduncalf deleted the td/fix-old-android-gradle branch July 6, 2022 11:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants