Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types and add a test for flexible sync client reset #4703

Merged
merged 5 commits into from
Jul 4, 2022

Conversation

tomduncalf
Copy link
Contributor

@tomduncalf tomduncalf commented Jul 4, 2022

What, How & Why?

I wanted to confirm this was working after a question from the docs team. It turns out our TS definition to only allow "manual" mode was a bit incorrect so I fixed it, and added a simple test which replicates the PBS one in the old tests

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@cla-bot cla-bot bot added the cla: yes label Jul 4, 2022
@tomduncalf tomduncalf changed the title change Testing CI Jul 4, 2022
@tomduncalf tomduncalf force-pushed the td/test-ci branch 2 times, most recently from 5e24d50 to 19a7d23 Compare July 4, 2022 16:15
@tomduncalf tomduncalf changed the title Testing CI Fix types and add a test for flexible sync client reset Jul 4, 2022
@tomduncalf
Copy link
Contributor Author

Merging this as it is a recreated #4702 (created to test out if it was my code making Catalyst CI fail somehow, but it seems to just be pure chance)

@tomduncalf tomduncalf merged commit 8261202 into master Jul 4, 2022
@tomduncalf tomduncalf deleted the td/test-ci branch July 4, 2022 17:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant