Adding type checking to the realm-app-importer #4688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
force-pushed
the
kh/typed-app-importer
branch
from
26e5669 to
9990a81
Compare
takameyer
approved these changes
Jun 30, 2022
| const apps: App[] = await response.json(); | ||
| const apps = await response.json(); | ||
| if (!isAppsResponse(apps)) { | ||
| throw new Error("Expected a response with apps"); |
There was a problem hiding this comment.
🚢 Maybe printing the invalid response would be helpful.
There was a problem hiding this comment.
But I can also handle this when I rebase this into my changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This adds type checking to the response objects returned from calling the admin API in the
realm-app-importerpackage.This was needed after an upgrade of
typescriptandeslinton thekh/npm-workspacesbranch. Making this a separate PR to ease review.☑️ ToDos
Compatibilitylabel is updated or copied from previous entrypackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary