Fixing analytics tests #4687
Merged
Fixing analytics tests #4687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneth
approved these changes
Jun 29, 2022
takameyer
pushed a commit
that referenced
this pull request
Jun 30, 2022
kraenhansen
added a commit
that referenced
this pull request
Jul 1, 2022
As a followup cleanup from #4687
8 tasks
kraenhansen
added a commit
that referenced
this pull request
Jul 1, 2022
* Delete leftover packages As a followup cleanup from #4687 * Delete rn-package.json * Delete electron-package.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This is a refactor / fix of our analytics tests to read a fixture from a directory instead of a single package.json file to reflect the implementation. This also updates the analytics code to work from a package path argument, instead of a package.json object.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entrypackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary