Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json to discard tag_prefix to make npm binary mirroring work #4672

Merged
merged 3 commits into from
Jun 24, 2022

Conversation

tomduncalf
Copy link
Contributor

@tomduncalf tomduncalf commented Jun 24, 2022

What, How & Why?

A user reported in #4667 that they cannot install Realm using npm "binary mirroring", which allows it to work in an environment with no internet connection and instead, an internal artefact server – I guess quite a common set up in finance, etc. This happened since v10, it used to work in v6.

They did some research and suggested that this change would fix the issue. They tested this branch and it did indeed fix the issue, but I have to confess I don't really understand the consequences of the change so would welcome any thoughts!

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@cla-bot cla-bot bot added the cla: yes label Jun 24, 2022
@tomduncalf tomduncalf requested review from kneth and kraenhansen June 24, 2022 08:49
Copy link
Contributor

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if the experience will be better if we migrate to Github releases instead of using S3?

@tomduncalf tomduncalf merged commit 6cf95fe into master Jun 24, 2022
@tomduncalf tomduncalf deleted the td/binary-mirroring-test branch June 24, 2022 15:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants