Update package.json to discard tag_prefix to make npm binary mirroring work #4672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
A user reported in #4667 that they cannot install Realm using npm "binary mirroring", which allows it to work in an environment with no internet connection and instead, an internal artefact server – I guess quite a common set up in finance, etc. This happened since v10, it used to work in v6.
They did some research and suggested that this change would fix the issue. They tested this branch and it did indeed fix the issue, but I have to confess I don't really understand the consequences of the change so would welcome any thoughts!
☑️ ToDos
Compatibility
label is updated or copied from previous entrypackage.json
s (if updating internal packages)Breaking
label has been applied or is not necessaryIf this PR adds or changes public API's: