-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update realm.io/common to 0.1.2 #4660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a common problem when we update our internal packages. We should set something up to catch this for us (or automate an update for dependent packages)
I'd expect the package-lock.json to update from this change? |
Yep @takameyer, I'll create a ticket for that as it is very easy to miss (and quite hard to catch as our @kraenhansen Good point, I'll do an npm/lerna to update them |
I just merged #4661, you should be able to simply rebase, to get a green Realm Web integration test. |
Added package lock in fb436c6 |
fb436c6
to
6b74854
Compare
What, How & Why?
This fixes #4657.
I'm going to look separately if I can create a failing test for this cas.
☑️ ToDos
Compatibility
label is updated or copied from previous entryBreaking
label has been applied or is not necessaryIf this PR adds or changes public API's: