Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update realm.io/common to 0.1.2 #4660

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Conversation

tomduncalf
Copy link
Contributor

@tomduncalf tomduncalf commented Jun 20, 2022

What, How & Why?

This fixes #4657.

I'm going to look separately if I can create a failing test for this cas.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a common problem when we update our internal packages. We should set something up to catch this for us (or automate an update for dependent packages)

@kraenhansen
Copy link
Member

I'd expect the package-lock.json to update from this change?

@tomduncalf
Copy link
Contributor Author

Yep @takameyer, I'll create a ticket for that as it is very easy to miss (and quite hard to catch as our package.json specifies ^0.1.1 so in many cases will pull in the right version for a clean install regardless, but seemingly not for an upgrade install).

@kraenhansen Good point, I'll do an npm/lerna to update them

@kraenhansen
Copy link
Member

I just merged #4661, you should be able to simply rebase, to get a green Realm Web integration test.

@tomduncalf
Copy link
Contributor Author

Added package lock in fb436c6

@tomduncalf tomduncalf force-pushed the td/update-realm-common-version branch from fb436c6 to 6b74854 Compare June 20, 2022 10:17
@tomduncalf tomduncalf merged commit fe0a896 into master Jun 20, 2022
@tomduncalf tomduncalf deleted the td/update-realm-common-version branch June 20, 2022 12:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem After Recently Updating Realm JS
4 participants