Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement polyfill for globalThis (v11) #4655

Closed
wants to merge 3 commits into from
Closed

Implement polyfill for globalThis (v11) #4655

wants to merge 3 commits into from

Conversation

tomduncalf
Copy link
Contributor

What, How & Why?

See #4653, this fixes one additional usage in v11

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@cla-bot cla-bot bot added the cla: yes label Jun 16, 2022
@tomduncalf tomduncalf mentioned this pull request Jun 16, 2022
Closed
10 tasks
kneth
kneth approved these changes Jun 17, 2022
View reviewed changes
package.json Outdated
@@ -80,7 +80,7 @@
"postinstall": "node scripts/submit-analytics.js"
},
"dependencies": {
"@realm.io/common": "^0.1.1",
"@realm.io/common": "^0.1.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the package to @realm/common soon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, created #4656

takameyer
takameyer approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but I am curious if this needs to be a separate commit in v11, or if we can just rebase this into that branch?

@tomduncalf tomduncalf added the Blocked This issue is blocked by another issue label Jun 24, 2022
@tomduncalf
Copy link
Contributor Author

Blocked waiting on v11 to be rebased on master

@kraenhansen kraenhansen force-pushed the v11 branch 2 times, most recently from adcc845 to 343d668 Compare July 12, 2022 09:07
@kneth kneth mentioned this pull request Aug 11, 2022
Closed
11 tasks
@kraenhansen kraenhansen force-pushed the v11 branch 6 times, most recently from bd551c6 to bb8ce55 Compare September 13, 2022 07:21
@kraenhansen kraenhansen force-pushed the v11 branch 2 times, most recently from 7674954 to 916ea33 Compare October 18, 2022 08:30
@tomduncalf tomduncalf changed the base branch from v11 to master October 24, 2022 10:04
@tomduncalf tomduncalf removed the Blocked This issue is blocked by another issue label Oct 24, 2022
@kneth kneth closed this Aug 28, 2023
@kneth kneth deleted the td/globalthis-v11 branch August 28, 2023 18:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kneth kneth kneth approved these changes

@takameyer takameyer takameyer approved these changes

@kraenhansen kraenhansen Awaiting requested review from kraenhansen

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomduncalf @takameyer @kneth