Upgrade to NDK r23c #4628
Closed
Upgrade to NDK r23c #4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takameyer
approved these changes
Jun 10, 2022
tomduncalf
approved these changes
Jun 10, 2022
kraenhansen
reviewed
Jun 17, 2022
kraenhansen
reviewed
Jun 17, 2022
|
My only concern with this, is that as we're shipping a pre-built binary, we need to ensure we're compiling with the same C++ standard library as the developer building their app. It's my understanding that the ABI of the standard library is provided by the NDK, is that correct? If so, how do we ensure these are matching out endusers? (this relates to the comment in the description of #4027) |
Co-authored-by: Andrew Meyer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This closes #3905
It simplifies building by using the same CMake and Ninja installation to build for all supported platforms (see
contrib/building.mdfor details).Note: Using latest version of Ninja with Github Actions leads to a fatal error. An older version works just fine. I observed the same error as in ninja-build/ninja#2048.
☑️ ToDos
[ ] 📝Compatibilitylabel is updated or copied from previous entry[ ] 🚦 Tests[ ] 🔀 Executed flexible sync tests locally if modifying flexible sync[ ] 📱 Check the React Native/other sample apps work if necessary[ ] 📝 Public documentation PR created or is not necessary[ ] 💥Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's:
[ ] typescript definitions file is updated[ ] jsdoc files updated[ ] Chrome debug API is updated if API is available on React Native