Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-ios to use xcode 13.1 #4606

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Update build-ios to use xcode 13.1 #4606

merged 1 commit into from
Jun 2, 2022

Conversation

tomduncalf
Copy link
Contributor

What, How & Why?

Updated to match latest Apple App Store requirements, Xcode 12 is no longer supported for uploading apps.

This closes #4605.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@tomduncalf tomduncalf marked this pull request as ready for review May 30, 2022 09:49
@cla-bot cla-bot bot added the cla: yes label May 30, 2022
@tomduncalf tomduncalf requested review from kneth and kraenhansen May 30, 2022 09:50
@kraenhansen
Copy link
Member

:shipit: Could we refactor by extracting a constant for the Xcode version (or app path) to make it easier to change in the future?

@kneth kneth merged commit eb6f1f7 into master Jun 2, 2022
@kneth kneth deleted the td/update-to-xcode-131 branch June 2, 2022 08:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update build-ios.sh to use Xcode 13.1
3 participants