Type Fix for Returned Schemas #4580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takameyer
force-pushed
the
andrew/canonical-schema-object
branch
from
8b5e99f to
955b530
Compare
kraenhansen
reviewed
May 18, 2022
takameyer
force-pushed
the
andrew/canonical-schema-object
branch
from
00df19b to
8a11e17
Compare
takameyer
commented
May 18, 2022
* The schema returned from an open realm has a different structure than the input schema for configuration. This structure has now been typed along with updated documentation. * Statically cast the returned schema as it is being used to dynamically update the schema
takameyer
force-pushed
the
andrew/canonical-schema-object
branch
from
8a11e17 to
f4b6432
Compare
|
Accidentally reviewed these changes as part of #4581 |
takameyer
force-pushed
the
andrew/canonical-schema-object
branch
from
e88d294 to
3a6a819
Compare
kneth
approved these changes
May 19, 2022
kraenhansen
reviewed
May 31, 2022
takameyer
force-pushed
the
andrew/canonical-schema-object
branch
from
ba76a01 to
1e22627
Compare
kraenhansen
approved these changes
May 31, 2022
takameyer
force-pushed
the
andrew/canonical-schema-object
branch
from
1e22627 to
a2a4c70
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
The schema returned from an open realm has a different structure than the input schema
for configuration. This structure has now been typed along with updated documentation.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryBreakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: