Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ObjectSchema from PropertiesTypes #4577

Merged
merged 1 commit into from
May 30, 2022
Merged

Remove ObjectSchema from PropertiesTypes #4577

merged 1 commit into from
May 30, 2022

Conversation

takameyer
Copy link
Contributor

@takameyer takameyer commented May 17, 2022

This is no longer a valid input for schema properties.
The documentation has also been updated.

This is not really a broken change, since this was already broken.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@cla-bot cla-bot bot added the cla: yes label May 17, 2022
This is no longer a valid input for schema properties.
The documentation has also been updated.
Copy link
Contributor

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor suggestion to changelog

@@ -5,7 +5,7 @@ x.x.x Release notes (yyyy-MM-dd)

### Fixed
* <How to hit and notice issue? what was the impact?> ([#????](https://github.com/realm/realm-js/issues/????), since v?.?.?)
* None.
* Fixed invalid type for schema properties([#4577](https://github.com/realm/realm-js/pull/4577)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fixed invalid type for schema properties([#4577](https://github.com/realm/realm-js/pull/4577)).
* Fixed invalid type for schema properties. ([#4577](https://github.com/realm/realm-js/pull/4577), since v10.0.0)

Copy link
Member

@kraenhansen kraenhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem reasonable. Good to get this cleaned up.

@takameyer takameyer merged commit 6f27600 into master May 30, 2022
@takameyer takameyer deleted the andrew/type-fix branch May 30, 2022 10:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants