-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Flexible Sync Configuration #4562
Conversation
This makes the flexible boolean incompatible with paritionValue, without setting tsconfig to false. It does however allow, flexible to be false, but thats a better tradeoff in the end.
834586a
to
d0d87d1
Compare
This makes the flexible boolean incompatible with paritionValue, without setting tsconfig to false. It does however allow, flexible to be false, but thats a better tradeoff in the end.
Just for a little more background on these changes, I found that instead of trying to make a type that supports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for finding this workaround! I've only made minor suggestions which you can choose to ignore if preferred
Co-authored-by: Tom Duncalf <[email protected]>
525a553
to
156504a
Compare
What, How & Why?
This makes the flexible boolean incompatible with paritionValue,
without setting tsconfig to false. It does however not allow,
flexible to be false, but that's a better tradeoff in the end.
This closes #4552
☑️ ToDos
Compatibility
label is updated or copied from previous entryBreaking
label has been applied or is not necessaryIf this PR adds or changes public API's: