Add test for clean exit from node #4556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomduncalf
force-pushed
the
td/4535-node-clean-exit
branch
from
232459d to
6767d91
Compare
kneth
approved these changes
May 5, 2022
kraenhansen
reviewed
May 5, 2022
| execSync( | ||
| `node -e 'const Realm = require("realm"); const app = new Realm.App({ id: "myapp-abcde" }); Realm.clearTestState();'`, | ||
| { | ||
| timeout: 5000, |
There was a problem hiding this comment.
I think this extends the timeout of the test? I.e. if it takes 3 seconds for the process to exit, it will fail although it didn't timeout. Could we read this timeout from the test's context instead?
Suggested change
| timeout: 5000, | |
| timeout: this.timeout - 100, |
There was a problem hiding this comment.
Ah yeah, good spot. How about this change: 924c7db so that it never exceeds either the test timeout or 5000ms?
I think 5000ms should always be enough for this test in any case, if you were running the suite with say 60 second timeout for some reason, there's no point in this one waiting for 60 seconds also.
tomduncalf
force-pushed
the
td/4535-node-clean-exit
branch
from
88213ea to
924c7db
Compare
kraenhansen
approved these changes
May 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This reproduces #4535
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryBreakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: