Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for copyBundledRealmFiles #4493

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

tomduncalf
Copy link
Contributor

@tomduncalf tomduncalf commented Apr 14, 2022

What, How & Why?

Right now there's nothing to really tell you how to use this method. Ben is working on updating the docs but I thought it was good to have it here too.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@cla-bot cla-bot bot added the cla: yes label Apr 14, 2022
@tomduncalf tomduncalf requested review from kneth and kraenhansen April 14, 2022 10:22
Copy link
Contributor

@mongodben mongodben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great improvement!

@kneth
Copy link
Contributor

kneth commented Apr 19, 2022

@tomduncalf Thank you for documenting the method.

@tomduncalf tomduncalf merged commit a5a7bcc into master Apr 19, 2022
@tomduncalf tomduncalf deleted the td/update-copybundledrealmfiles-doc branch April 19, 2022 07:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants