Add script to generate JS template apps from TS #4374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomduncalf
changed the title
tomduncalf
commented
Feb 25, 2022
| # Strip types from every .ts* file (except those in node_modules) and write the output | ||
| # to the corresponding file in react-native-template-realm-js, with the extension changed | ||
| # to ".js" (regardless of whether the original was ".tsx" or ".ts") | ||
| for i in `find . -path ./node_modules -prune -o -name "*.ts*" -print`; do npx detype $i $2/${i/\.ts*/\.js} ; done |
There was a problem hiding this comment.
@takameyer I'm wondering if maybe this should only convert files in app/, and delete all the *.ts* files in there first in case we delete/rename a file... WDYT?
There was a problem hiding this comment.
That makes sense. We should probably move the App.tsx into app/ as well?
takameyer
approved these changes
Feb 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Currently we have to manually sync our JS template apps with our TS template apps, which has led to them slipping out of sync.
This PR adds a script which strips the types out of the TS apps and writes the output into the JS template apps, using the detype npm package (tsc does not preserve comments and whitespace).
It also updates the JS apps with the output of the script.
A future enhancement might be to have the
react-native-template-realm-tsas the "master" app, then we copy theappdirectory from there into the Expo template as part of this script, and generate the JS apps. This would mean we only have to maintain one set of app code, but each template could have its own supporting code.☑️ ToDos
Compatibilitylabel is updated or copied from previous entryBreakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: