Remove code which was causing proxy crash #4257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash could be reproduced with e.g.:
```
people = realm.objects(Person);
peopleProxy = new Proxy(people, {get: () => {} });
Object.prototype.toString.call(peopleProxy);
```
tomduncalf
force-pushed
the
td/proxy-fix
branch
from
3480f64 to
84d0fde
Compare
kneth
reviewed
Jan 25, 2022
takameyer
approved these changes
Jan 25, 2022
|
I wonder if this could help with another Proxy problem and Hermes? #4119 |
|
@somebody32 unfortunately not. This PR applies only to our Node.js integration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crash could be reproduced with e.g.:
What, How & Why?
This closes # ???
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryBreakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: