-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for arrayFilters in updates #4248
Conversation
This PR is for the feature request [realm#4247](realm#4247). This PR adds support for arrayFilters by passing the arrayFilters parameter to the Realm serverless function. Additional testing was added to cover the case of an update with arrayFilters.
@joellord I have initiated CI on your PR, and I will report back the result. |
Fixed the linting errors. |
I see that there is a test that fails, but I'm quite confused as to how to go to fix it. It seems like the test runner didn't have the credentials for docker. |
I did a new PR with your changes (to allow our integration tests to run) and got this result: https://github.com/realm/realm-js/runs/4950056552?check_suite_focus=true
|
Now that #4265 is green, I believe its safe to merge. |
Thank you @joellord! I just spent the morning working on array identifiers in MongoDB Realm only to realize that they don't work on |
* Adding support for arrayFilters in updates This PR is for the feature request [#4247](#4247). This PR adds support for arrayFilters by passing the arrayFilters parameter to the Realm serverless function. Additional testing was added to cover the case of an update with arrayFilters. * Fix linting errors * Reverted change in package.json that caused tests to fail * Fixing the test to insert a single item * Update CHANGELOG.md * Update CHANGELOG.md * Trying to get those tests to pass * Update remote-mongodb-service.test.ts Co-authored-by: Kræn Hansen <[email protected]> Co-authored-by: Kræn Hansen <[email protected]>
What, How & Why?
This PR is for the feature request #4247.
This PR adds support for arrayFilters by passing the arrayFilters parameter to the Realm serverless function.
Additional testing was added to cover the case of an update with arrayFilters.
This closes #4247
☑️ ToDos
Compatibility
label is updated or copied from previous entryBreaking
label has been applied or is not necessaryIf this PR adds or changes public API's: