Update Jenkinsfile to use NPM CLI v8 on Windows #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealebenpae
approved these changes
Jan 13, 2022
Comment on lines
+240
to
+241
| bat "nodist add ${nodeVersion}" | ||
| bat "nodist npm add ${npmVersion}" |
There was a problem hiding this comment.
Suggested change
| bat "nodist add ${nodeVersion}" | |
| bat "nodist npm add ${npmVersion}" | |
| bat """ | |
| nodist add ${nodeVersion} | |
| nodist npm add ${npmVersion} | |
| """ |
You can use a single shell block to run both commands.
There was a problem hiding this comment.
Thanks for the suggestion. I like the simplicity of separating these. In my opinion it makes it simpler to determine what command failed.
| @@ -505,9 +509,11 @@ def testWindows(nodeVersion) { | |||
| node('windows && nodist') { | |||
| unstash 'source' | |||
| bat "nodist add ${nodeVersion}" | |||
| bat "nodist npm add ${npmVersion}" | |||
There was a problem hiding this comment.
You can run both commands in a single block, see previous suggestion.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This fixes #4202
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryBreakinglabel has been applied or is not necessary