Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Realm Core 11.6.0. Was: Adopting to changes in Realm Core (past 11.4.1) #4023

Merged
merged 3 commits into from
Nov 10, 2021

Conversation

kraenhansen
Copy link
Member

What, How & Why?

I needed to consume an unreleased version of Realm Core after v11.4.1.
This PR contains the modifications I had to do to adopt to the changes in Realm Core.

Feel free to merge this PR into whatever branch we'll be using when upgrading Realm Core to the version after 11.4.1, once that gets released.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@cla-bot cla-bot bot added the cla: yes label Oct 13, 2021
@kraenhansen kraenhansen changed the title Adopting to changes in Realm Core Adopting to changes in Realm Core (past 11.4.1) Oct 13, 2021
@kraenhansen kraenhansen self-assigned this Oct 13, 2021
@kneth kneth force-pushed the kh/realm-core-after-11.4.1 branch from 7751c72 to d861347 Compare October 26, 2021 13:52
@cla-bot cla-bot bot added the cla: yes label Oct 26, 2021
@kraenhansen kraenhansen marked this pull request as ready for review October 29, 2021 19:00
@kraenhansen kraenhansen force-pushed the kh/realm-core-after-11.4.1 branch from 84e9581 to 5da103d Compare November 1, 2021 12:17
@kraenhansen
Copy link
Member Author

I rebased on latest master. I'll merge as soon as we've got a green build.

Copy link

@fronck fronck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ironage
Copy link
Contributor

ironage commented Nov 2, 2021

FYI, core v11.5.2 had a regression with streaming download notifiers, you may wish to hold of releasing this until the next core version which will include realm/realm-core#5008

@tomduncalf
Copy link
Contributor

Using this for my sync branch and it works 👍

@kneth kneth changed the title Adopting to changes in Realm Core (past 11.4.1) Upgrade to Realm Core 11.6.0. Was: Adopting to changes in Realm Core (past 11.4.1) Nov 10, 2021
@kraenhansen kraenhansen force-pushed the kh/realm-core-after-11.4.1 branch from 7f8d658 to b154e1a Compare November 10, 2021 14:43
@kraenhansen kraenhansen merged commit 535bea5 into master Nov 10, 2021
@kraenhansen kraenhansen deleted the kh/realm-core-after-11.4.1 branch November 10, 2021 17:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants