Get Realm.Object property type #3938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
approved these changes
Sep 1, 2021
kraenhansen
reviewed
Sep 1, 2021
tests/js/object-tests.js
Outdated
|
|
||
| testGetPropertyType: function () { | ||
| const realm = new Realm({ | ||
| schema: [schemas.AllTypes, schemas.TestObject, schemas.LinkToAllTypes], |
There was a problem hiding this comment.
Oh actually: I would love to see a test using a property of type mixed as well. To verify that it's the underlying type and not simply the type from the schema which gets returned.
|
This also needs an updated changelog.md |
kneth
reviewed
Sep 2, 2021
src/js_realm_object.hpp
Outdated
| throw std::invalid_argument(util::format("No such property: %1", property_name)); | ||
| } | ||
|
|
||
| return_value.set(prop->type_string()); |
There was a problem hiding this comment.
To get the JavaScript names, you need to call TypeErrorException::type_string(prop) (https://github.com/realm/realm-js/blob/master/src/js_realm.cpp#L78).
If prop->type_string() == "mixed", you need to unwrap the property. It is something like:
auto obj = realm_object->obj();
DataType typ = obj.get().get_type();
// convert typ to string
kneth
force-pushed
the
jose/get-property-type
branch
from
794a028 to
f9fb1dd
Compare
kraenhansen
approved these changes
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Since all numeric types (int, long, double) are represented as a
numberwhen read from our SDK, it makes sense to implement a method to get the underlying type of the property value, if your application (such as MongoDB Realm Studio) cares about this. Throws an exception if a property with the given name does not exist.E.g.
This closes #3646
☑️ ToDos
[ ] 📝Compatibilitylabel is updated or copied from previous entry[ ] 💥Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: