Fixing "Right-hand side of 'instanceof' is not an object" and adding dictionary integration tests (again)

CHANGELOG.md

@@ -4,7 +4,8 @@ x.x.x Release notes (yyyy-MM-dd)
 * None.
 
 ### Fixed
-* Fix TypeScript definition of `Realm.Dictionary.remove()`. (since v10.6.0)
+* Fixed TypeScript definition of `Realm.Dictionary.remove()`. (since v10.6.0)
+* Fixed Realm.Object#toJSON as it threw "Right-hand side of 'instanceof' is not an object". (since v10.6.0)
 
 ### Compatibility
 * MongoDB Realm Cloud.

integration-tests/environments/react-native/harness/runner.js

@@ -27,7 +27,7 @@ const logcat = require("./logcat");
 const IOS_DEVICE_NAME = "realm-js-integration-tests";
 const IOS_DEVICE_TYPE_ID = "com.apple.CoreSimulator.SimDeviceType.iPhone-11";
 
-const { MOCHA_REMOTE_PORT, PLATFORM, HEADLESS_DEBUGGER, SPAWN_LOGCAT } = process.env;
+const { MOCHA_REMOTE_PORT, PLATFORM, HEADLESS_DEBUGGER, SPAWN_LOGCAT, SKIP_RUNNER } = process.env;
 
 if (typeof PLATFORM !== "string") {
   throw new Error("Expected a 'PLATFORM' environment variable");
@@ -204,6 +204,10 @@ function optionalStringToBoolean(value) {
 }
 
 if (module.parent === null) {
+  if (SKIP_RUNNER === "true") {
+    console.log("Skipping the runner - you're on your own");
+    process.exit(0);
+  }
   const headlessDebugger = optionalStringToBoolean(HEADLESS_DEBUGGER);
   const spawnLogcat = optionalStringToBoolean(SPAWN_LOGCAT);
   run(headlessDebugger, spawnLogcat).catch((err) => {

integration-tests/environments/react-native/ios/RealmReactNativeTests/AppDelegate.m

@@ -53,7 +53,8 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
 - (NSURL *)sourceURLForBridge:(RCTBridge *)bridge
 {
 #if DEBUG
-  return [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index" fallbackResource:nil];
+  // Fetching with inlineSourceMap=true to ease debugging.
+  return [NSURL URLWithString:[[[[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index" fallbackResource:nil] absoluteString] stringByAppendingString:@"&inlineSourceMap=true" ]];
 #else
   return [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
 #endif

integration-tests/tests/src/hooks/open-realm-before.ts

@@ -24,8 +24,8 @@ type SyncedConfiguration = Omit<Realm.Configuration, "sync"> & {
   sync?: Partial<Realm.SyncConfiguration>;
 };
 
-export function openRealmBefore(config: LocalConfiguration | SyncedConfiguration = {}): void {
-  before(async function (this: Partial<RealmContext> & Mocha.Context) {
+export function openRealmHook(config: LocalConfiguration | SyncedConfiguration = {}) {
+  return async function openRealm(this: Partial<RealmContext> & Mocha.Context): Promise<void> {
     const nonce = new Realm.BSON.ObjectID().toHexString();
     const path = `temp-${nonce}.realm`;
     if (this.realm) {
@@ -48,23 +48,32 @@ export function openRealmBefore(config: LocalConfiguration | SyncedConfiguration
       // Upload the schema, ensuring a valid connection
       await this.realm.syncSession.uploadAllLocalChanges();
     }
-  });
+  };
+}
 
-  // Clean up afterwards
-  after(function (this: RealmContext) {
-    if (this.realm) {
-      this.realm.close();
-      delete this.realm;
-    } else {
-      throw new Error("Expected a 'realm' in the context");
-    }
-    if (this.config) {
-      Realm.deleteFile(this.config);
-      delete this.config;
-    } else {
-      throw new Error("Expected a 'config' in the context");
-    }
-    // Clearing the test state to ensure the sync session gets completely reset and nothing is cached between tests
-    Realm.clearTestState();
-  });
+export function closeRealm(this: RealmContext): void {
+  if (this.realm) {
+    this.realm.close();
+    delete this.realm;
+  } else {
+    throw new Error("Expected a 'realm' in the context");
+  }
+  if (this.config) {
+    Realm.deleteFile(this.config);
+    delete this.config;
+  } else {
+    throw new Error("Expected a 'config' in the context");
+  }
+  // Clearing the test state to ensure the sync session gets completely reset and nothing is cached between tests
+  Realm.clearTestState();
+}
+
+export function openRealmBeforeEach(config: LocalConfiguration | SyncedConfiguration = {}): void {
+  beforeEach(openRealmHook(config));
+  afterEach(closeRealm);
+}
+
+export function openRealmBefore(config: LocalConfiguration | SyncedConfiguration = {}): void {
+  before(openRealmHook(config));
+  after(closeRealm);
 }

integration-tests/tests/src/index.ts

@@ -46,5 +46,6 @@ require("./tests/objects");
 require("./tests/iterators");
 require("./tests/dynamic-schema-updates");
 require("./tests/bson");
+require("./tests/dictionary");
 require("./tests/credentials/anonymous");
 require("./tests/sync/mixed");