Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Set prototype resolution #3843

Merged
merged 5 commits into from
Jul 26, 2021
Merged

Fix for Set prototype resolution #3843

merged 5 commits into from
Jul 26, 2021

Conversation

fronck
Copy link

@fronck fronck commented Jul 9, 2021

What, How & Why?

Fix type resolution for Set so that it works under Jest, node, and RN.

This closes #3788

☑️ ToDos

  • 📝 Changelog entry
    * [ ] 📝 Compatibility label is updated or copied from previous entry
    * [ ] 🚦 Tests
    * [ ] 📝 Public documentation PR created or is not necessary
    * [ ] 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:
* [ ] typescript definitions file is updated
* [ ] jsdoc files updated
* [ ] Chrome debug API is updated if API is available on React Native

@fronck fronck force-pushed the ff/fix_realm_ndef_jest_new branch from dfea32f to 493592d Compare July 15, 2021 15:05
@fronck fronck requested review from kneth and takameyer July 15, 2021 15:07
@fronck fronck marked this pull request as ready for review July 15, 2021 15:07
@fronck fronck requested a review from takameyer July 15, 2021 15:24
Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only suggestion would be to add a failing test to this PR. Otherwise LGTM

Copy link
Contributor

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might apply the same trick to Dictionary.

@fronck fronck force-pushed the ff/fix_realm_ndef_jest_new branch from 6980799 to 9ba54d3 Compare July 26, 2021 09:42
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@fronck fronck force-pushed the ff/fix_realm_ndef_jest_new branch from 9d4d29c to 7ef0627 Compare July 26, 2021 10:00
@fronck fronck force-pushed the ff/fix_realm_ndef_jest_new branch from 7ef0627 to e859a93 Compare July 26, 2021 14:57
@fronck fronck merged commit c1fc086 into master Jul 26, 2021
@fronck fronck deleted the ff/fix_realm_ndef_jest_new branch July 26, 2021 15:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Realm is not defined" when iterating through Realm Sets using Jest
3 participants