-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Set prototype resolution #3843
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fronck
force-pushed
the
ff/fix_realm_ndef_jest_new
branch
from
July 15, 2021 15:05
dfea32f
to
493592d
Compare
takameyer
reviewed
Jul 15, 2021
takameyer
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only suggestion would be to add a failing test to this PR. Otherwise LGTM
kneth
approved these changes
Jul 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might apply the same trick to Dictionary.
fronck
force-pushed
the
ff/fix_realm_ndef_jest_new
branch
from
July 26, 2021 09:42
6980799
to
9ba54d3
Compare
fronck
commented
Jul 26, 2021
fronck
commented
Jul 26, 2021
fronck
force-pushed
the
ff/fix_realm_ndef_jest_new
branch
from
July 26, 2021 10:00
9d4d29c
to
7ef0627
Compare
Co-authored-by: Andrew Meyer <[email protected]>
fronck
force-pushed
the
ff/fix_realm_ndef_jest_new
branch
from
July 26, 2021 14:57
7ef0627
to
e859a93
Compare
fronck
pushed a commit
that referenced
this pull request
Nov 25, 2021
9 tasks
fronck
pushed a commit
that referenced
this pull request
Dec 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Fix type resolution for Set so that it works under Jest, node, and RN.
This closes #3788
☑️ ToDos
* [ ] 📝Compatibility
label is updated or copied from previous entry* [ ] 🚦 Tests* [ ] 📝 Public documentation PR created or is not necessary* [ ] 💥Breaking
label has been applied or is not necessaryIf this PR adds or changes public API's:
* [ ] typescript definitions file is updated* [ ] jsdoc files updated* [ ] Chrome debug API is updated if API is available on React Native