-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate configuration #3772
Validate configuration #3772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is disableFormatUpgrade
an option compatible with sync? I would imagine that this would prevent Sync from writing to the file. Additionally, we should express these incompatibilities in the typescript definitions so that people who are using an editor that respects ts definitions will get early feedback if they try to construct an invalid config.
dd7ebe9
to
d60c373
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a formatting issue that should be addressed.
I am not completely satisfied with how the typings resolve for configuration, but I have no alternative solution at the moment. If the developer explicitly uses ConfigurationWithSync
, then the TS errors look nice, but if they use the Configuration
union, the TS errors are quite vague. If I come up with a better solution later, I will make a separate PR.
Otherwise, LGTM
Co-authored-by: Andrew Meyer <[email protected]>
What, How & Why?
This closes #3771
☑️ ToDos
[ ] 📝Compatibility
label is updated or copied from previous entry[ ] 📝 Public documentation PR created or is not necessary[ ] 💥Breaking
label has been applied or is not necessaryIf this PR adds or changes public API's:
[ ] jsdoc files updated[ ] Chrome debug API is updated if API is available on React Native