Update prebuild-install and lock runtime #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneth
suggested changes
Apr 8, 2021
takameyer
force-pushed
the
andrew/prebuild-install-napi
branch
from
6b9625e to
b54410a
Compare
|
Reverted change to core version |
kneth
approved these changes
Apr 9, 2021
In preparation for github actions, we need to update prebuild-install to allow for local installation of a prebuild package. This is provided in version 6.1.1. Also, since in the binary.package_name field, the napi runtime is hardcoded, we have also hardcoded the runtime into the install script for prebuild-install.
takameyer
force-pushed
the
andrew/prebuild-install-napi
branch
from
b54410a to
8474734
Compare
fealebenpae
approved these changes
Apr 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for github actions, we need to update prebuild-install to allow for
local installation of a prebuild package. This is provided in version 6.1.1.
Also, in the binary.package_name field the
napiruntime is hardcoded.The runtime is now hard coded into the install script for
prebuild-install, as we don't support any other runtimes.This closes #3670
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryBreakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: