Alternative fix for #3236 that avoids causing #3503 #3505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with the fix in #3340 was that it was causing the EventLoopDispatcher to be constructed on the sync thread rather than on the JS thread, which is required. This alternative fix initializes it on the JS thread, but ensures it is re-initialized when RN apps are reloaded.
steffenagger
approved these changes
Jan 15, 2021
Closed
blagoev
approved these changes
Jan 15, 2021
kneth
approved these changes
Jan 15, 2021
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
The problem with the fix in #3340 was that it was causing the
EventLoopDispatcher to be constructed on the sync thread rather than on the JS
thread, which is required. This alternative fix initializes it on the JS
thread, but ensures it is re-initialized when RN apps are reloaded.
This closes #3503.
@reviewers: first commit is a revert of #3340, second commit is the alternate fix. I suggest reviewing each commit separately rather than combined.
☑️ ToDos
[ ] 📝Compatibilitylabel is updated or copied from previous entry[ ] 🚦 Tests[ ] 📝 Public documentation PR created or is not necessary[ ] 💥Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's:
[ ] typescript definitions file is updated[ ] jsdoc files updated[ ] Chrome debug API is updated if API is available on React Native