Exposing all data of the profile.data on User#profile, renamed userId… #3481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on indentities elements and exposed providerType on a User
8 tasks
kneth
suggested changes
Dec 18, 2020
| return { | ||
| id: identity.id, | ||
| providerId: identity["provider_id"], | ||
| // providerId: identity["provider_id"], |
There was a problem hiding this comment.
Probably 😊 I might have wanted to leave it in as a signal that this is infact also returned from the API, but it should probably be removed.
docs/sync.js
Outdated
| */ | ||
|
|
||
| /** | ||
| * Describes an error when an incompatible synced Realm is opened. The old version of the Realm can be accessed in readonly mode using the configuration() member |
There was a problem hiding this comment.
This is the description of IncompatibleSyncedRealmError. We need a correct description of UserIdentity.
jsflax
approved these changes
Jan 4, 2021
cesarvr
approved these changes
Jan 4, 2021
kneth
approved these changes
Jan 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Merging this PR will:
profile.dataonUser#profile(Realm Web only - still missing on Realm JS)userIdtoidonUser#identitieselements (Realm JS and types)providerTypeon aUser(Realm Web).This closes #3268 and a few other untracked issues.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryBreakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: