Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling back some of PR #3356 #3436

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Rolling back some of PR #3356 #3436

merged 1 commit into from
Dec 3, 2020

Conversation

steffenagger
Copy link
Contributor

This reverts a part of #3356

Realm' s toJSON should not make assumptions as to how ArrayBuffers are serialized.
This change would also be a challenge to devs, who are currently using toJSON for purposes other than serialization.

Sidenote: @kraenhansen I'll implement toJSON for ArrayBuffer in Studio v10 (soon).

Merge at will.

(just for clarification these changes were originally made by me..)

@steffenagger steffenagger merged commit 9272820 into master Dec 3, 2020
@steffenagger steffenagger deleted the sa/pr-3356-rollback branch December 3, 2020 09:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants