Realm Web: allUser object keyed by ids #3346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blagoev
reviewed
Oct 16, 2020
| @@ -259,7 +259,7 @@ declare namespace Realm { | |||
| * All authenticated users. | |||
| */ | |||
| readonly allUsers: Readonly< | |||
| User<FunctionsFactoryType, CustomDataType>[] | |||
| Record<string, User<FunctionsFactoryType, CustomDataType>> | |||
There was a problem hiding this comment.
this needs a changelog entry in Realm JS
There was a problem hiding this comment.
@steffenagger suggested this one
* Fixed TS declaration for app.allUserstoRecord<string, User>instead ofArray ([#3346](https://github.com/realm/realm-js/pull/3346))
steffenagger
approved these changes
Oct 16, 2020
kraenhansen
force-pushed
the
kh/web/all-users-object
branch
from
0805107 to
88ddd3b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This closes RJS-869 by aligning with the Realm JS (and other SDKs) implementation of the
allUsersproperty on an instance ofApp.☑️ ToDos
Compatibilitylabel is updated or copied from previous entryBreakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: