Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realm Web: App "services" and "functions" removed #3298

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This closes a part of #3256 by removing the services and functions members from instances of App, to align with Realm JS and other SDKs.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@kraenhansen kraenhansen self-assigned this Oct 5, 2020
Copy link
Contributor

@steffenagger steffenagger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kraenhansen kraenhansen merged commit 46010cb into v10 Oct 6, 2020
@kraenhansen kraenhansen deleted the kh/web/app-services-removed branch October 6, 2020 10:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants