Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: isLoggedIn boolean property on User (v10) #3294

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Web: isLoggedIn boolean property on User (v10) #3294

merged 1 commit into from
Oct 5, 2020

Conversation

steffenagger
Copy link
Contributor

user.isLoggedIn now returns a booelan.
(this also add isLoggedIn to the shared TS declarations)

@steffenagger steffenagger self-assigned this Oct 5, 2020
kraenhansen
kraenhansen approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@kraenhansen kraenhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@steffenagger steffenagger merged commit a344dd1 into v10 Oct 5, 2020
@steffenagger steffenagger deleted the sa/web/user.isLoggedIn branch October 5, 2020 14:47
@steffenagger steffenagger mentioned this pull request Oct 5, 2020
Merged
@bmunkholm
Copy link
Contributor

@steffenagger The PR template should not be deleted. It's there to ensure we remember to add release notes for instance ;-)
And as a reminder for the reviewer @kraenhansen ;-)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kraenhansen kraenhansen kraenhansen approved these changes

Assignees

@steffenagger steffenagger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steffenagger @bmunkholm @kraenhansen