Fix for TS create declarations when updating (v6) #3271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal
Initiated based on this comment: #3044 (comment) - v10 PR can be found here: #3266.
Allow for partial models when using
Realm.UpdateMode.All
orRealm.UpdateMode.Modified
create<T>
declarations has been updated to:Additional changes
objectForPrimaryKey<T>
updated to:The above change limits the use of
realm.objectForPrimaryKey(Person)
to only accept Class Model which extendsRealm.Object
(just likeobjects<T>(...)
is currently declared).I extended integration-tests for object creation/reading to include update-tests, a
objectForPrimaryKey
test & include Class Models in testing (these additions only works in combination with the merged #3261).And fixed an issue with serialization tests (so it now works in different environments - the previous error message check was a bit too specific, as described here (MDN)).
☑️ ToDos
If this PR adds or changes public API's: