Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Realm.Credentials.{function, google}() to RN debugger support #3265

Merged
merged 6 commits into from
Oct 1, 2020
Merged

Add missing Realm.Credentials.{function, google}() to RN debugger support #3265

merged 6 commits into from
Oct 1, 2020

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Sep 25, 2020 •
edited
Loading

What, How & Why?

Solving one part of #3236
Closes #3279

☑️ ToDos

  • 📝 Changelog entry
  • [ ] 📝 Compatibility label is updated or copied from previous entry
  • [ ] 🚦 Tests
  • [ ] 📝 Public documentation PR created or is not necessary
  • [ ] 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • [ ] typescript definitions file is updated
  • [ ] jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@kneth kneth self-assigned this Sep 25, 2020
steffenagger
steffenagger approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@steffenagger steffenagger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kneth kneth mentioned this pull request Oct 1, 2020
Closed
@kneth kneth changed the title Add missing Realm.Credentials.function() to RN debugger support Add missing Realm.Credentials.{function, google}() to RN debugger support Oct 1, 2020
kraenhansen
kraenhansen approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@kraenhansen kraenhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right.

@kneth kneth closed this Oct 1, 2020
@kneth kneth reopened this Oct 1, 2020
@kneth kneth merged commit 921d528 into v10 Oct 1, 2020
@kneth kneth deleted the kneth/v10/add-functions-to-rn-debug branch October 1, 2020 13:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steffenagger steffenagger steffenagger approved these changes

@blagoev blagoev blagoev approved these changes

@kraenhansen kraenhansen kraenhansen approved these changes

Assignees

@kneth kneth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kneth @kraenhansen @blagoev @steffenagger