bugfix: toJSON internal cache ids resulting in wrong data #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneth
approved these changes
Sep 24, 2020
steffenagger
force-pushed
the
sa/tojson-cache-id-fix
branch
from
6be9ac2 to
c5350f9
Compare
steffenagger
force-pushed
the
sa/tojson-cache-id-fix
branch
from
c5350f9 to
04b657b
Compare
blagoev
approved these changes
Sep 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on
this.constructor.namewas a bad idea. This fix switches to usingobjectSchema.nameinstead.This fixes #3254