Disallow realm migration on synced realms #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fronck
changed the title
added 2 commits
September 21, 2020 14:31
kneth
approved these changes
Sep 22, 2020
blagoev
reviewed
Sep 23, 2020
blagoev
approved these changes
Sep 23, 2020
This was referenced Nov 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Now throws an error when client requests a realm that is both synced and has
deleteRealmIfMigrationNeededenabled. These options are incompatible.Added test that checks functionality.
This closes #RJS-755 / HELP-18006.
☑️ ToDos
* [ ] 📝Compatibilitylabel is updated or copied from previous entry* [] 📝 Public documentation PR created or is not necessary* [ ] 💥Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's:
* [ ] typescript definitions file is updated* [ ] Chrome debug API is updated if API is available on React Native