Fix type/objectType for lists of ObjectId/Decimal128 #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng_for_property_type.
blagoev
approved these changes
Sep 18, 2020
kneth
approved these changes
Sep 21, 2020
| @@ -145,7 +145,7 @@ static inline void parse_property_type(StringData object_name, Property& prop, S | |||
| prop.object_type = ""; | |||
| } | |||
| else if (prop.object_type == "objectId") { | |||
| prop.type |= PropertyType::Decimal | PropertyType::Array; | |||
| prop.type |= PropertyType::ObjectId | PropertyType::Array; | |||
|
Please add an entry in |
22 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Lists of
ObjectIdorDecimal128still returns'object id'&'decimal'instead of'objectId'&'decimal128', when checkingtype/objectType.Solution:
A util method
local_string_for_property_typehas been introduced, wrapping OSstring_for_property_type- this is now used instead ofstring_for_property_type.Tests expanded to include checks for
objectType.