Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix v10 CI tests #3159

Merged
merged 62 commits into from
Oct 9, 2020
Merged

fix v10 CI tests #3159

merged 62 commits into from
Oct 9, 2020

Conversation

blagoev
Copy link
Contributor

@blagoev blagoev commented Aug 24, 2020

fix CI tests for v10

@steffenagger
Copy link
Contributor

I checked out this branch, and cleaned build folders etc.
Then executed: (cd scripts && sh test.sh react-tests)

But I'm getting:

In file included from /[local-path]/realm/js/tests/react-test-app/node_modules/realm/src/object-store/src/sync/push_client.cpp:19:
In file included from object-store/src/sync/push_client.hpp:22:
In file included from object-store/src/sync/auth_request_client.hpp:21:
object-store/src/sync/generic_network_transport.hpp:23:10: fatal error: 'realm/util/to_string.hpp' file not found
#include <realm/util/to_string.hpp>

Am I missing a step, or doing something wrong?

@kraenhansen
Copy link
Member

Am I missing a step, or doing something wrong?

Did you git submodule update --recursive?

@steffenagger
Copy link
Contributor

Did you git submodule update --recursive?

I hadn't, but same result.

@blagoev blagoev changed the title fix v10 RN tests fix v10 CI tests Oct 8, 2020
Copy link
Member

@kraenhansen kraenhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few places that I think we should mention in #3312

tests/electron/package.json Outdated Show resolved Hide resolved
tests/electron/package.json Outdated Show resolved Hide resolved
tests/js/encryption-tests.js Show resolved Hide resolved
tests/js/index.js Show resolved Hide resolved
tests/js/index.js Show resolved Hide resolved
tests/js/realm-tests.js Show resolved Hide resolved
tests/js/support/testConfig.js Show resolved Hide resolved
tests/js/support/testConfig.js Show resolved Hide resolved
tests/js/support/testConfig.js Show resolved Hide resolved
tests/js/support/testConfig.js Show resolved Hide resolved
@blagoev blagoev requested a review from kraenhansen October 8, 2020 12:51
Copy link
Member

@kraenhansen kraenhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why the suggested change to const nodeRequire = require won't work, but we can iterate on that later.

@blagoev
Copy link
Contributor Author

blagoev commented Oct 8, 2020

@kraenhansen this won't be able to hide it from the analyzer. Check how we are doing that on every other place.

Copy link
Contributor

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My single comment is more a question.

@blagoev
Copy link
Contributor Author

blagoev commented Oct 9, 2020

merging this one

@blagoev blagoev merged commit a8e39b4 into v10 Oct 9, 2020
@blagoev blagoev deleted the fix-RN-tests-v10 branch October 9, 2020 07:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants