-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix v10 CI tests #3159
fix v10 CI tests #3159
Conversation
…' into fix-RN-tests-v10
I checked out this branch, and cleaned build folders etc. But I'm getting: In file included from /[local-path]/realm/js/tests/react-test-app/node_modules/realm/src/object-store/src/sync/push_client.cpp:19:
In file included from object-store/src/sync/push_client.hpp:22:
In file included from object-store/src/sync/auth_request_client.hpp:21:
object-store/src/sync/generic_network_transport.hpp:23:10: fatal error: 'realm/util/to_string.hpp' file not found
#include <realm/util/to_string.hpp> Am I missing a step, or doing something wrong? |
Did you |
I hadn't, but same result. |
…into fix-RN-tests-v10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few places that I think we should mention in #3312
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why the suggested change to const nodeRequire = require
won't work, but we can iterate on that later.
@kraenhansen this won't be able to hide it from the analyzer. Check how we are doing that on every other place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. My single comment is more a question.
merging this one |
fix CI tests for v10