Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix realm.delete for RealmObjects not inheriting from RealmObjectCons… #3100

Merged
merged 5 commits into from
Jul 30, 2020
Merged

fix realm.delete for RealmObjects not inheriting from RealmObjectCons… #3100

merged 5 commits into from
Jul 30, 2020

Conversation

blagoev
Copy link
Contributor

@blagoev blagoev commented Jul 29, 2020 •
edited
Loading

fixes #2848 in v10
fixes #2893

@blagoev blagoev requested a review from steffenagger July 29, 2020 16:01
steffenagger
steffenagger approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@steffenagger steffenagger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blagoev blagoev merged commit e4636fe into v10 Jul 30, 2020
@blagoev blagoev deleted the v10-fix-RN-delete-class-syntax branch July 30, 2020 12:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steffenagger steffenagger steffenagger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blagoev @steffenagger