-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Android and XCode builds #3074
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit 👍
I suppose this was introduced with #2995?
…js into kneth/v10/fix-android-build
@@ -21,7 +22,7 @@ NOTE: This version bumps the Realm file format to version 11. It is not possible | |||
* File format: generates Realms with format v11 (reads and upgrades file format v5 or later). | |||
|
|||
### Internal | |||
* None. | |||
* Realm Object Store updated to commit 9c80160881f2af76d99c356a9d6017c88c9b7e52. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to provide updates on what changed in there and in what way are we describing all these changes here. @bmunkholm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not if it's just internal changes. The commit is enough. Obviously anything that affect the end users should go the top sections (but assume that's not what you meant).
What, How & Why?
This closes #3069
☑️ ToDos
[ ] 📝Compatibility
label is updated or copied from previous entry[ ] 🚦 Tests[ ] 📝 Public documentation PR created or is not necessary[ ] 💥Breaking
label has been applied or is not necessaryIf this PR adds or changes public API's:
[ ] typescript definitions file is updated[ ] jsdoc files updated[ ] Chrome debug API is updated if API is available on React Native