Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android and XCode builds #3074

Merged
merged 5 commits into from
Aug 17, 2020
Merged

Fix Android and XCode builds #3074

merged 5 commits into from
Aug 17, 2020

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Jul 19, 2020

What, How & Why?

This closes #3069

☑️ ToDos

  • 📝 Changelog entry
  • [ ] 📝 Compatibility label is updated or copied from previous entry
  • [ ] 🚦 Tests
  • [ ] 📝 Public documentation PR created or is not necessary
  • [ ] 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • [ ] typescript definitions file is updated
  • [ ] jsdoc files updated
  • [ ] Chrome debug API is updated if API is available on React Native

@kneth kneth self-assigned this Jul 19, 2020
@kneth kneth added the T-Bug label Jul 19, 2020
Copy link
Member

@kraenhansen kraenhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 👍
I suppose this was introduced with #2995?

@@ -21,7 +22,7 @@ NOTE: This version bumps the Realm file format to version 11. It is not possible
* File format: generates Realms with format v11 (reads and upgrades file format v5 or later).

### Internal
* None.
* Realm Object Store updated to commit 9c80160881f2af76d99c356a9d6017c88c9b7e52.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to provide updates on what changed in there and in what way are we describing all these changes here. @bmunkholm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not if it's just internal changes. The commit is enough. Obviously anything that affect the end users should go the top sections (but assume that's not what you meant).

@kneth kneth merged commit a9f9110 into v10 Aug 17, 2020
@kneth kneth deleted the kneth/v10/fix-android-build branch August 17, 2020 07:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants