-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EmailPasswordAuth renames #3048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneth
approved these changes
Jul 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename src/js_email_password_provider.hpp
to src/js_email_password_auth.hpp
to let class name and file name be aligned?
@kneth totally - I forgot that! Thanks :) |
kraenhansen
pushed a commit
that referenced
this pull request
Jul 10, 2020
* Renamed to js_email_password_auth.hpp, email-password-auth-methods.js and api-key-auth-methods.js * Adding a note in the changelog * Updated docs * Renamed to EmailPasswordAuth
kraenhansen
added a commit
that referenced
this pull request
Jul 10, 2020
* Updating package locks from release * Merging types and adjusting configs * Fixed linting issues * Merged the auth provider types * Updated types related to auth providers * Fixing the functions factory types * Fixed integration tests based on updated types * Made options optional when using the HTTP service * Delete the commented App class declaration * Merge types and update code accordingly * Package-lock got updated * Fixed logging out a logged out user * Commented out the App#logOut method * Adding removeUser to the tests * Update types/app.d.ts Co-authored-by: Kenneth Geisshirt <[email protected]> * Removed "| void" * resendConfirmation → resendConfirmationEmail * Removed logOut method from the `App` * Fixed App constructor type * Using unshift instead of splice where applicable * Adopted API to the latest proposal * Fixed the realm-network-transport types * Updating integration tests * ApiKeyAuth renames (#3047) * Renamed UserAPIKeyProvider to ApiKeyAuth * Renaming instance methods * Moved from user.auth.apiKeys to user.apiKeys * Renamed js_user_apikey_provider.hpp to js_api_key_auth.hpp * Updated the jsdocs * Adding apiKeys to the browser proxy * Adding a note in the changelog * EmailPasswordAuth renames (#3048) * Renamed to js_email_password_auth.hpp, email-password-auth-methods.js and api-key-auth-methods.js * Adding a note in the changelog * Updated docs * Renamed to EmailPasswordAuth * Moved push service to a seperate interface * Implemented a throwing push for a user * Incorporated feedback * v10 refactoring (#2996) * registerEmail -> registerUser * Realm.User.identity -> Realm.User.id. Realm.User.token -> Realm.User.accessToken. Add Realm.User.refreshToken. * Turn Realm.App.{currentUser, allUsers} to an instance property * Add Realm.Auth.EmailPassword.callResetPasswordFunction * Wrongly merged * Removed UserProfile from index.d.ts and updated pictureUrl Co-authored-by: Kenneth Geisshirt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This closes part of #2980 by renaming the
EmailPasswordProvider
toEmailPasswordAuth
and restructuring according to the types.☑️ ToDos
Compatibility
label is updated or copied from previous entryBreaking
label has been applied or is not necessaryIf this PR adds or changes public API's: