Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmailPasswordAuth renames #3048

Merged
merged 4 commits into from
Jul 10, 2020
Merged

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This closes part of #2980 by renaming the EmailPasswordProvider to EmailPasswordAuth and restructuring according to the types.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@kraenhansen kraenhansen requested a review from kneth July 10, 2020 08:32
@kraenhansen kraenhansen self-assigned this Jul 10, 2020
@kraenhansen kraenhansen changed the base branch from master to kh/v10-merged-types July 10, 2020 08:32
Copy link
Contributor

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename src/js_email_password_provider.hpp to src/js_email_password_auth.hpp to let class name and file name be aligned?

@kraenhansen
Copy link
Member Author

@kneth totally - I forgot that! Thanks :)

@kraenhansen kraenhansen merged commit 349b594 into kh/v10-merged-types Jul 10, 2020
@kraenhansen kraenhansen deleted the kh/v10/email-password-auth branch July 10, 2020 10:23
@kraenhansen kraenhansen restored the kh/v10/email-password-auth branch July 10, 2020 10:24
kraenhansen pushed a commit that referenced this pull request Jul 10, 2020
    * Renamed to js_email_password_auth.hpp, email-password-auth-methods.js and api-key-auth-methods.js
    * Adding a note in the changelog
    * Updated docs
    * Renamed to EmailPasswordAuth
kraenhansen added a commit that referenced this pull request Jul 10, 2020
* Updating package locks from release

* Merging types and adjusting configs

* Fixed linting issues

* Merged the auth provider types

* Updated types related to auth providers

* Fixing the functions factory types

* Fixed integration tests based on updated types

* Made options optional when using the HTTP service

* Delete the commented App class declaration

* Merge types and update code accordingly

* Package-lock got updated

* Fixed logging out a logged out user

* Commented out the App#logOut method

* Adding removeUser to the tests

* Update types/app.d.ts

Co-authored-by: Kenneth Geisshirt <[email protected]>

* Removed "| void"

* resendConfirmation → resendConfirmationEmail

* Removed logOut method from the `App`

* Fixed App constructor type

* Using unshift instead of splice where applicable

* Adopted API to the latest proposal

* Fixed the realm-network-transport types

* Updating integration tests

* ApiKeyAuth renames (#3047)

* Renamed UserAPIKeyProvider to ApiKeyAuth

* Renaming instance methods

* Moved from user.auth.apiKeys to user.apiKeys

* Renamed js_user_apikey_provider.hpp to js_api_key_auth.hpp

* Updated the jsdocs

* Adding apiKeys to the browser proxy

* Adding a note in the changelog

* EmailPasswordAuth renames (#3048)

    * Renamed to js_email_password_auth.hpp, email-password-auth-methods.js and api-key-auth-methods.js
    * Adding a note in the changelog
    * Updated docs
    * Renamed to EmailPasswordAuth

* Moved push service to a seperate interface

* Implemented a throwing push for a user

* Incorporated feedback

* v10 refactoring (#2996)

* registerEmail -> registerUser

* Realm.User.identity -> Realm.User.id. Realm.User.token -> Realm.User.accessToken. Add Realm.User.refreshToken.

* Turn Realm.App.{currentUser, allUsers} to an instance property

* Add Realm.Auth.EmailPassword.callResetPasswordFunction

* Wrongly merged

* Removed UserProfile from index.d.ts and updated pictureUrl

Co-authored-by: Kenneth Geisshirt <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants