Testing new datatypes #2797
Merged
Testing new datatypes #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g object store. Add tests of embedded objects.
blagoev
approved these changes
Apr 16, 2020
| @@ -1412,13 +1412,72 @@ module.exports = { | |||
|
|
|||
| testCreateEmbeddedObjects: function() { | |||
| const realm = new Realm({schema: [schemas.ContactSchema, schemas.AddressSchema]}); | |||
| realm.write(() => { // FIXME: This should not be required! | |||
There was a problem hiding this comment.
Yes, it is fixed on the kneth/stitch-integration branch (by fixing Realm.clearTestState()).
| for (let i = 0; i < numbers.length; i++) { | ||
| let d128 = objects[i]['decimalCol']; | ||
| TestCase.assertTrue(d128 instanceof Decimal128); | ||
| TestCase.assertEqual(d128.toString(), numbers[i].toUpperCase()); |
There was a problem hiding this comment.
it will be really nice if we could add an equals(x: string): boolean to all decimals128 values which does the comparison with the correct casing. I looked at https://github.com/mongodb/js-bson/blob/master/lib/decimal128.js and strangely enough there is no such thing
Do you think we can add such method in this PR?
There was a problem hiding this comment.
envisioning this as d128.equals(string)
|
|
||
| for (let i = 0; i < values.length; i++) { | ||
| let oid2 = objects[i]['id']; | ||
| TestCase.assertTrue(oid2 instanceof ObjectId, 'instaceof'); |
There was a problem hiding this comment.
there is an TestCase.assertInstanceOf method
| TestCase.assertEqual(oid2.toHexString(), oid1.toHexString()); | ||
| values.forEach(v => { | ||
| let oid = ObjectId.createFromTime(v); | ||
| realm.write(() => { |
There was a problem hiding this comment.
why not have the realm.write wrap the forEach
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Updating to latest core/sync/object store and adding more testing. Related to:
The
Decimal128tests will fail as outlined in realm/realm-core#3679☑️ ToDos
[ ] 📝Compatibilitylabel is updated or copied from previous entry[ ] 📝 Public documentation PR created or is not necessary[ ] 💥Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's:
[ ] typescript definitions file is updated[ ] jsdoc files updated[ ] Chrome debug API is updated if API is available on React Native