Handle sync config in Realm.deleteFile #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneth
reviewed
Oct 3, 2018
| realm::Realm::Config config; | ||
|
|
||
| static const String path_string = "path"; | ||
| ValueType path_value = Object::get_property(ctx, object, path_string); | ||
| ValueType path_value = Object::get_property(ctx, config_object, path_string); |
There was a problem hiding this comment.
Can it be moved after line 771 and before 772?
There was a problem hiding this comment.
Ugh 😑 It can, but will look ugly
kneth
approved these changes
Oct 4, 2018
nirinchev
force-pushed
the
ni/delete-file-sync-config
branch
from
3924e27 to
3d84731
Compare
bmunkholm
approved these changes
Oct 4, 2018
|
The test failure seems unrelated to these changes, so I'll go ahead and merge this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This allows us to delete Realm files by passing in a sync config.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entry📝 Public documentation PR created or is not necessary💥Breakinglabel has been applied or is not necessary