Align permission API's with Java/Swift #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lib/index.d.ts # lib/user-methods.js
|
Ready for review |
kneth
reviewed
Sep 28, 2018
docs/permission.js
Outdated
| * If the Permission object is created because one didn't exist already, it will be | ||
| * created with all privileges disabled. | ||
| * | ||
| * If the Role object is created because one didn't exists, it will be created |
docs/permission.js
Outdated
|
|
||
| /** | ||
| * Finds the Class-level permissions associated with the named Role. If either the role or the permission | ||
| * object doesn't exists, it will be created. |
docs/permission.js
Outdated
|
|
||
| /** | ||
| * Finds the Realm-level permissions associated with the named Role. If either the role or the permission | ||
| * object doesn't exists, it will be created. |
CHANGELOG.md
Outdated
| @@ -1,8 +1,13 @@ | |||
| x.x.x Release notes (yyyy-MM-dd) | |||
| ============================================================= | |||
| ## Enhancements | |||
| * None | |||
|
|
|||
| * Added support for finding Realm-level permissions in Query-based Realms using `realm.getPermissions()` ([#2036] | |||
There was a problem hiding this comment.
Please move . to end of sentence: "Added ... using realm.getPermissions(). ([..."
docs/realm.js
Outdated
| /** | ||
| * Returns the fine-grained permissions object associated with either the Realm itself or a Realm model class. | ||
| * | ||
| * @param {Realm~ObjectType} [arg] - If no argument is provided, the Realm-level permissions are are returned. |
lib/extensions.js
Outdated
| } | ||
|
|
||
| // Realm instance methods that are available always available |
|
Changelog is fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the JS API with Java/Swift by introducing a number of helper methods.
It adds
TODO:
permissions()method + testfindOrCreate(roleName)+ testsIn order for Realm to pick up extra methods on model classes we have to register the Javascript constructor function with Realm. This, unfortunately, means I have to revert the change by Nabil and move it back to JS land, but it is done in a way compatible with the C++ implementation so that
new Realm(config)will also include the schema. This is done by adding the internal_constructormethod as wrapping the original constructor itself seemed to cause other places in our code base (and possible client code as well).