Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: support ASDF #2031

Closed
breezeight opened this issue Sep 19, 2018 · 1 comment · Fixed by #2032
Closed

Feature request: support ASDF #2031

breezeight opened this issue Sep 19, 2018 · 1 comment · Fixed by #2032
Labels
O-Community

Comments

@breezeight
Copy link
Contributor

Goals

Our team use ASDF to manage node versions.

We XCode run a script with /bin/sh it sets a custom PATH env var which doesn't include asdf shims and the node command installed by asdf is not found as you can see below in "Actual Results".

To support ASDF I added this to the "Download Core" build phase:

if [[ -d "$HOME/.asdf/shims" ]]; then
    export PATH=$HOME/.asdf/shims:$PATH
fi

I'll submit a pull request

Expected Results

Build succeed.

Actual Results

/Users/nicolabrisotto/Library/Developer/Xcode/DerivedData/RealmJS-amkmngqitcyloggiqlpjufwqspfz/Build/Intermediates.noindex/RealmJS.build/Debug-iphonesimulator/RealmJS.build/Script-F63FF2C51C12462600B3B8E0.sh: line 14: node: command not found
Command /bin/sh failed with exit code 127

Steps to Reproduce

Install nodejs with asdf and build src/RealmJS.xcodeproj

Version of Realm and Tooling

  • Realm JS SDK Version: v2.15.3
  • Node or React Native: node v8.12.0
  • Client OS & Version: OSX
breezeight added a commit to pitchtarget/realm-js that referenced this issue Sep 19, 2018
@breezeight
Support ASDF shims
56f1487 
Add support to asdf shims as described here realm#2031
@breezeight breezeight mentioned this issue Sep 19, 2018
Merged
@realm-probot
Copy link

realm-probot bot commented Sep 19, 2018

Hey - looks like you forgot to add a T:* label - could you please add one?

kneth pushed a commit that referenced this issue Sep 19, 2018
@breezeight @kneth
Support ASDF shims (#2032)
6e58f1f 
* Support ASDF shims
Add support to asdf shims as described here #2031
* Updated changelog, ASDF Enhancements
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
O-Community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support ASDF shims pitchtarget/realm-js
1 participant
@breezeight