Skip to content

Commit

Permalink
Fix Warning in Gradle
Browse files Browse the repository at this point in the history
When using Realm in React Native projects, Gradle was complaining the way
applicationId was being declared (using a deprecated method).  This
PR tries to fix this issue.

This fixes #3879
  • Loading branch information
takameyer committed Aug 6, 2021
1 parent c5528b7 commit c29b6c9
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 2,460 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ x.x.x Release notes (yyyy-MM-dd)

### Fixed
* <How to hit and notice issue? what was the impact?> ([#????](https://github.com/realm/realm-js/issues/????), since v?.?.?)
* Remove deprecation warning when building for Android ([#3870](https://github.com/realm/realm-js/issues/????))
* None.

### Compatibility
Expand Down
1 change: 1 addition & 0 deletions react-native/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ android {
defaultConfig {
minSdkVersion rootProject.hasProperty("minSdkVersion") ? rootProject.minSdkVersion : 16
targetSdkVersion rootProject.hasProperty("targetSdkVersion") ? rootProject.targetSdkVersion : 28
applicationId getAppId()
}

tasks.withType(JavaCompile) {
Expand Down
Loading

0 comments on commit c29b6c9

Please sign in to comment.