Skip to content

Commit

Permalink
Clean up JavaScriptCore & legacy Chrome debugger RPC layer (#4203)
Browse files Browse the repository at this point in the history
* Removed 0xd3adc0d3

* Providing a "soft" landing for users running in legacy debugging mode

* Simplified index.js as we have react-native/index.js

* Removed some logging

* Adding a note to the CHANGELOG

* Stop integration testing in legacy debug mode

* Incorporated feedback

* Fixed the environment check 🤦‍♂️

* Removed all mentions of GCDWebServer
  • Loading branch information
kraenhansen authored Jan 17, 2022
1 parent f7a3aa0 commit a6c11af
Show file tree
Hide file tree
Showing 58 changed files with 57 additions and 7,880 deletions.
23 changes: 0 additions & 23 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -221,16 +221,6 @@ jobs:
MOCHA_REMOTE_EXIT_ON_ERROR: true
RETRIES: 5
RETRY_DELAY: 300000 # 5 min
- name: Run tests (${{matrix.platform.name}} / Chrome Debugging)
if: ${{ false }}
run: npm run test:${{matrix.platform.name}}:chrome --prefix integration-tests/environments/react-native
env:
MOCHA_REMOTE_CONTEXT: missingServer
MOCHA_REMOTE_REPORTER: mocha-github-actions-reporter
MOCHA_REMOTE_EXIT_ON_ERROR: true
HEADLESS_DEBUGGER: true
RETRIES: 5
RETRY_DELAY: 300000 # 5 min
react-native-android:
name: React Native on Android (${{ matrix.type }} using ${{ matrix.engine }})
runs-on: macos-latest
Expand Down Expand Up @@ -308,16 +298,3 @@ jobs:
MOCHA_REMOTE_REPORTER: mocha-github-actions-reporter
MOCHA_REMOTE_EXIT_ON_ERROR: true
SPAWN_LOGCAT: true
- name: Run tests (Android / Chrome Debugging)
if: ${{ false }}
uses: reactivecircus/android-emulator-runner@v2
with:
api-level: 29
target: google_apis
script: npm run test:android:chrome --prefix integration-tests/environments/react-native
env:
MOCHA_REMOTE_CONTEXT: missingServer
MOCHA_REMOTE_REPORTER: mocha-github-actions-reporter
MOCHA_REMOTE_EXIT_ON_ERROR: true
HEADLESS_DEBUGGER: true
SPAWN_LOGCAT: true
3 changes: 0 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
[submodule "vendor/GCDWebServer"]
path = vendor/GCDWebServer
url = https://github.com/swisspol/GCDWebServer.git
[submodule "docs/jsdoc-template"]
path = docs/jsdoc-template
url = https://github.com/realm/realm-jsdoc.git
Expand Down
23 changes: 23 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,26 @@
x.x.x Release notes (yyyy-MM-dd)
=============================================================
### Breaking change
* Removed all code related to the legacy Chrome Debugger. Please use [Flipper](https://fbflipper.com/) as debugger.

### Enhancements
* None.

### Fixed
* None.

### Compatibility
* MongoDB Realm Cloud.
* Realm Studio v11.0.0.
* APIs are backwards compatible with all previous releases of Realm JavaScript in the 10.5.x series.
* File format: generates Realms with format v22 (reads and upgrades file format v5 or later for non-synced Realm, upgrades file format v10 or later for synced Realms).

### Internal
* Remove the previous implementation to the JavaScriptCore engine (in `src/jsc`).
* <Either mention core version or upgrade>
* <Using Realm Core vX.Y.Z>
* <Upgraded Realm Core from vX.Y.Z to vA.B.C>

10.20.0-beta.0 Release notes (2021-12-21)
=============================================================
NOTE: This release is rebased on our `10.11.0` release and as such contain the same enhancements and fixes.
Expand Down
6 changes: 0 additions & 6 deletions Realm.xcworkspace/xcshareddata/Realm.xcscmblueprint
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"DVTSourceControlWorkspaceBlueprintIdentifierKey" : "5EE721F9-041C-4877-9E73-A925C9DB080A",
"DVTSourceControlWorkspaceBlueprintWorkingCopyPathsKey" : {
"40F53A12E4AE40C654358321B91166ABD3E910A6" : "realm-js\/",
"F6F96CA34C5878B0A9123C7C37855491A5E599DA" : "realm-js\/vendor\/GCDWebServer\/",
"8F3C415DA79CDA7D23734F285B95F9F9A3C0CB81" : "realm-js\/src\/object-store\/"
},
"DVTSourceControlWorkspaceBlueprintNameKey" : "Realm",
Expand All @@ -27,11 +26,6 @@
"DVTSourceControlWorkspaceBlueprintRemoteRepositoryURLKey" : "https:\/\/github.com\/realm\/realm-object-store.git",
"DVTSourceControlWorkspaceBlueprintRemoteRepositorySystemKey" : "com.apple.dt.Xcode.sourcecontrol.Git",
"DVTSourceControlWorkspaceBlueprintRemoteRepositoryIdentifierKey" : "8F3C415DA79CDA7D23734F285B95F9F9A3C0CB81"
},
{
"DVTSourceControlWorkspaceBlueprintRemoteRepositoryURLKey" : "https:\/\/github.com\/swisspol\/GCDWebServer.git",
"DVTSourceControlWorkspaceBlueprintRemoteRepositorySystemKey" : "com.apple.dt.Xcode.sourcecontrol.Git",
"DVTSourceControlWorkspaceBlueprintRemoteRepositoryIdentifierKey" : "F6F96CA34C5878B0A9123C7C37855491A5E599DA"
}
]
}
2 changes: 0 additions & 2 deletions RealmJS.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,4 @@ Pod::Spec.new do |s|
s.vendored_frameworks = 'react-native/ios/realm-js-ios.xcframework'

s.dependency 'React'
# TODO: Ensure the same version of GCDWebServer is used for Android
# s.dependency 'GCDWebServer'
end
19 changes: 0 additions & 19 deletions lib/browser/.eslintrc.json

This file was deleted.

70 changes: 0 additions & 70 deletions lib/browser/app.js

This file was deleted.

32 changes: 0 additions & 32 deletions lib/browser/async-open-task.js

This file was deleted.

84 changes: 0 additions & 84 deletions lib/browser/base64.js

This file was deleted.

35 changes: 0 additions & 35 deletions lib/browser/cache.js

This file was deleted.

Loading

0 comments on commit a6c11af

Please sign in to comment.