Skip to content

Commit

Permalink
Incorporating feedback on #6508
Browse files Browse the repository at this point in the history
  • Loading branch information
kraenhansen committed Feb 28, 2024
1 parent 3cb9c46 commit 6e60915
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 22 deletions.
3 changes: 2 additions & 1 deletion packages/realm/src/ObjectListeners.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ export type ObjectChangeSet<T> = {
export type ObjectChangeCallback<T> = (
/**
* The object that changed.
*/ object: RealmObject<T> & T,
*/
object: RealmObject<T> & T,
/**
* A dictionary with information about the changes.
*/
Expand Down
8 changes: 4 additions & 4 deletions packages/realm/src/OrderedCollection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,22 +51,22 @@ export type CollectionChangeSet = {
*/
insertions: number[];
/**
* The indices in the collection where objects were modified.
* The indices in the collection where objects were deleted.
*/
deletions: number[];
/**
* The indices in the collection where objects were modified.
* The indices in the new state of the collection where objects were modified.
*/
newModifications: number[];
/**
* The indices in the collection where objects were deleted.
* The indices in the old state of the collection where objects were modified.
*/
oldModifications: number[];
};

export type CollectionChangeCallback<T = unknown, EntryType extends [unknown, unknown] = [unknown, unknown]> = (
/**
* The collection instance that changed,
* The collection instance that changed.
*/
collection: OrderedCollection<T, EntryType>,
/**
Expand Down
16 changes: 8 additions & 8 deletions packages/realm/src/Realm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1305,21 +1305,21 @@ export namespace Realm {
export import WatchOptionsIds = internal.WatchOptionsIds;

// Deprecated exports below
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.AppServicesFunction} */
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.AppServicesFunction | AppServicesFunction} */
export import RealmFunction = internal.AppServicesFunction;
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.CanonicalPropertySchema} */
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.CanonicalPropertySchema | CanonicalPropertySchema} */
export import CanonicalObjectSchemaProperty = internal.CanonicalPropertySchema;
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.ClientResetRecoverUnsyncedChangesConfiguration} */
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.ClientResetRecoverUnsyncedChangesConfiguration | ClientResetRecoverUnsyncedChangesConfiguration} */
export import ClientResetRecoveryConfiguration = internal.ClientResetRecoverUnsyncedChangesConfiguration;
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.PropertySchema} */
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.PropertySchema | PropertySchema} */
export import ObjectSchemaProperty = internal.PropertySchema;
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.RealmObjectConstructor} */
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.RealmObjectConstructor | RealmObjectConstructor} */
export import ObjectClass = internal.RealmObjectConstructor;
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.PropertyTypeName} */
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.PropertyTypeName | PropertyTypeName} */
export import PropertyType = internal.PropertyTypeName;
/** @deprecated Use the another {@link internal.ClientResetMode} than {@link internal.ClientResetMode.Manual}. */
/** @deprecated Use the another {@link internal.ClientResetMode | ClientResetMode} than {@link internal.ClientResetMode.Manual | ClientResetMode.Manual}. */
export import ClientResetError = internal.ClientResetError;
/** @deprecated Use the another {@link internal.ClientResetMode} than {@link internal.ClientResetMode.Manual}. */
/** @deprecated See https://www.mongodb.com/docs/atlas/app-services/reference/push-notifications/ */
export import PushClient = internal.PushClient;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/realm/src/app-services/Sync.ts
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ export namespace Sync {
export import SubscriptionOptions = internal.SubscriptionOptions;
export import SubscriptionSet = internal.SubscriptionSet;
export import SubscriptionSetState = internal.SubscriptionSetState;
/** @deprecated Please use {@link internal.SubscriptionSetState} */
/** @deprecated Please use {@link internal.SubscriptionSetState | SubscriptionSetState} */
export import SubscriptionsState = internal.SubscriptionSetState;
export import Subscription = internal.Subscription;
export import Session = internal.SyncSession;
Expand Down
16 changes: 8 additions & 8 deletions packages/realm/src/deprecated-global.ts
Original file line number Diff line number Diff line change
Expand Up @@ -193,21 +193,21 @@ declare global {
export import WatchOptionsIds = internal.WatchOptionsIds;

// Deprecated exports below
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.AppServicesFunction} */
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.AppServicesFunction | AppServicesFunction} */
export import RealmFunction = internal.AppServicesFunction;
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.CanonicalPropertySchema} */
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.CanonicalPropertySchema | CanonicalPropertySchema} */
export import CanonicalObjectSchemaProperty = internal.CanonicalPropertySchema;
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.ClientResetRecoverUnsyncedChangesConfiguration} */
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.ClientResetRecoverUnsyncedChangesConfiguration | ClientResetRecoverUnsyncedChangesConfiguration} */
export import ClientResetRecoveryConfiguration = internal.ClientResetRecoverUnsyncedChangesConfiguration;
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.PropertySchema} */
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.PropertySchema | PropertySchema} */
export import ObjectSchemaProperty = internal.PropertySchema;
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.RealmObjectConstructor} */
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.RealmObjectConstructor | RealmObjectConstructor} */
export import ObjectClass = internal.RealmObjectConstructor;
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.PropertyTypeName} */
/** @deprecated Will be removed in v13.0.0. Please use {@link internal.PropertyTypeName | PropertyTypeName} */
export import PropertyType = internal.PropertyTypeName;
/** @deprecated Use the another {@link internal.ClientResetMode} than {@link internal.ClientResetMode.Manual}. */
/** @deprecated Use the another {@link internal.ClientResetMode | ClientResetMode} than {@link internal.ClientResetMode.Manual | ClientResetMode.Manual}. */
export import ClientResetError = internal.ClientResetError;
/** @deprecated Use the another {@link internal.ClientResetMode} than {@link internal.ClientResetMode.Manual}. */
/** @deprecated See https://www.mongodb.com/docs/atlas/app-services/reference/push-notifications/ */
export import PushClient = internal.PushClient;
}
}

0 comments on commit 6e60915

Please sign in to comment.