Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when negating query with empty group #7234

Draft
wants to merge 2 commits into
base: releases
Choose a base branch
from
Draft

Fix crash when negating query with empty group #7234

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4f6a52
Add tests for queries with empty groups
rorbech Dec 4, 2020
fe78b9c
Updates according to code review
rorbech Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions realm/realm-library/src/androidTest/java/io/realm/RealmQueryTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,41 @@ public void not() {
}
}

@Test
public void emptyGroup() {
populateTestRealm(); // create TEST_DATA_SIZE objects
RealmResults<AllTypes> fives = realm.where(AllTypes.class)
.equalTo(AllTypes.FIELD_LONG, 5)
.beginGroup()
.endGroup()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this throw as well?

Copy link
Contributor Author

@rorbech rorbech Dec 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No 🤷

.findAll();
// Only on object with value 5
assertEquals(1, fives.size());
}

@Test (expected = UnsupportedOperationException.class)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, we only reserve this exception to things not implemented. A more appropriate exception would be IllegalStateException

Copy link
Contributor Author

@rorbech rorbech Dec 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From documentation of the various RealmQuery methods it seems like invalid queries (syntax errors) are indicated by throwing UnsupportedOperationException.

public void or_emptyGroupThrows() {
populateTestRealm(); // create TEST_DATA_SIZE objects
RealmResults<AllTypes> fives = realm.where(AllTypes.class)
rorbech marked this conversation as resolved.
Show resolved Hide resolved
.equalTo(AllTypes.FIELD_LONG, 5)
.or()
.beginGroup()
.endGroup()
.findAll();
}

@Test (expected = UnsupportedOperationException.class)
public void not_emptyGroup_throws() {
populateTestRealm(); // create TEST_DATA_SIZE objects
realm.where(AllTypes.class)
.equalTo(AllTypes.FIELD_LONG, 5)
.or()
.not()
.beginGroup()
.endGroup()
.findAll();
}

@Test (expected = UnsupportedOperationException.class)
public void not_aloneThrows() {
// a not() alone must fail
Expand Down