Update to latest Core #3016
Merged
Update to latest Core #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| NativeMethods.report_error_for_testing(this, errorCode, errorCategory, errorMessage, (IntPtr)errorMessage.Length, isFatal); | ||
| NativeMethods.report_error_for_testing(this, errorCode, errorCategory, errorMessage, (IntPtr)errorMessage.Length, isFatal, (int)action); |
Check notice
Code scanning / CodeQL
Calls to unmanaged code
| return handle_errors(ex, [=]() { | ||
| auto context = new ManagedNotificationTokenContext(); | ||
| context->managed_object = managed_dict; | ||
| context->token = dictionary->add_key_based_notification_callback([context](DictionaryChangeSet changes) { |
Check notice
Code scanning / CodeQL
Large object passed by value
| auto context = new ManagedNotificationTokenContext(); | ||
| context->managed_object = managed_object; | ||
| context->schema = schema; | ||
| context->token = subscriber([context](CollectionChangeSet changes) { |
Check notice
Code scanning / CodeQL
Large object passed by value
fealebenpae
approved these changes
Aug 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Core removed the exception from collection notifiers. It's also pulling in fix for realm/realm-core#4865 which allows us to remove some
WaitForDownloads.