Target .NET 6 #2906
Merged
Target .NET 6 #2906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Tools/SetupUnityPackage/CommandLineOptions/RealmOptions.cs # wrappers/build-ios.ps1 # wrappers/build-ios.sh
Pull Request Test Coverage Report for Build 2190169135
💛 - Coveralls |
nirinchev
approved these changes
Apr 19, 2022
| retention-days: 1 | ||
| ios: | ||
| runs-on: macos-latest | ||
| name: iOS XCframework |
There was a problem hiding this comment.
Are we no longer producing an xcframework?
There was a problem hiding this comment.
No, we ship the device framework under runtimes/ios and the simulator framework under runtimes/iossimulator.
| <PackagePath>contentFiles\any\xamarinios\$(AssemblyName).dll.config</PackagePath> | ||
| <PackageCopyToOutput>true</PackageCopyToOutput> | ||
| </Content> | ||
| <Content Include="wrappers-props\xamarinios\wrappers.props" Pack="true" PackagePath="build\xamarinios\Realm.props" /> |
There was a problem hiding this comment.
Is build/xamarinios the folder being used both for Xamarin.iOS and net6-ios TFMs?
There was a problem hiding this comment.
No, it's only the Xamarin.iOS TFM that uses it.
fealebenpae
force-pushed
the
yg/net6-targeting
branch
from
ec5189b to
4accfac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our NuGet package with support for
net6-androidandnet6-iosruntimes:runtimes/ios/nativeandruntimes/iossimulator/native, respectively.runtimes/android-${ABI}/native.realm-wrappers.frameworkbinary at runtime. .NET 6 introduces theNativeLibraryAPI that allows native library resolution to be controlled at runtime.monoandroid,xamarinios,xamarinmac, andnet461. Everything else relies on NuGet to resolve runtime-specific binaries from the rightruntimesfolder.