-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement list of nullables with minimal refactorings #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3052154069
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3125627969
💛 - Coveralls |
nirinchev
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, even though I'd have preferred the const schema approach.
desistefanova
approved these changes
Sep 20, 2022
nielsenko
force-pushed
the
kn/nullable-in-collections-no-refactoring
branch
7 times, most recently
from
September 23, 2022 11:40
f94c072
to
b027b2c
Compare
blagoev
suggested changes
Sep 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just want to make sure we have noticed the change in my comment.
nielsenko
force-pushed
the
kn/nullable-in-collections-no-refactoring
branch
from
September 23, 2022 19:27
b027b2c
to
043695c
Compare
nielsenko
force-pushed
the
kn/nullable-in-collections-no-refactoring
branch
from
September 23, 2022 20:00
043695c
to
a6ef9fc
Compare
nielsenko
force-pushed
the
kn/nullable-in-collections-no-refactoring
branch
from
September 26, 2022 06:46
a6e72f7
to
0cad63f
Compare
blagoev
approved these changes
Sep 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow list of nullable primitives in realm models, such as:
Fixes #163 (supersedes #708)